Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mirtop collapse nftest #382

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add mirtop collapse nftest #382

merged 2 commits into from
Aug 21, 2024

Conversation

atrigila
Copy link

@atrigila atrigila commented Aug 21, 2024 •
edited
Loading

Add nf-test to local module using custom R script. Useful to track changes regarding how the collapsing of mirtop data is going to be performed and which miRNAs will remain.
#174

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila self-assigned this Aug 21, 2024
@atrigila atrigila added this to the 2.4.0 milestone Aug 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 21, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit fc679ce

+| ✅ 213 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-21 14:40:32

@atrigila atrigila marked this pull request as ready for review August 21, 2024 15:35
apeltzer
apeltzer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - testing is never a bad idea 👍🏻

@apeltzer apeltzer merged commit f8fd872 into nf-core:dev Aug 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

@grst grst Awaiting requested review from grst

@nschcolnicov nschcolnicov Awaiting requested review from nschcolnicov

Assignees

@atrigila atrigila

Labels
None yet
Projects
smrnaseq
Status: Done
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@atrigila @apeltzer